-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto detect import externalId field #178
Conversation
I have test it and it works. Need a review and merge. |
maybe we can even improove it by adding a magic wand matching
but we need a validation layout with: wdyt ? |
Hi @dufoli, Could you create your branch from releaseCandidate and use this target branch when updating the PR ? |
f6e4c98
to
637a450
Compare
@tprouvot that s done ;-) |
Hi @dufoli , I'm facing an issue during my tests, could you have a check ? |
J'ai corrigé. |
I have improved it by adding a refresh function in order to guess all column after change of object type (by selection or auto selection when it is guessed from first column of import. |
ready for new review |
rebase |
@tprouvot any news for review ? |
@dufoli |
Yes |
I have take another look and see that i remove trim by mistake |
Hey @dufoli happy new year ! |
ee2a100
to
3b597f8
Compare
hello, I have recheck. It is a matter of async call of describeInfo because didUpdate do nothing and when we call for first time cache of object is empty. So I have change the way of update by doing it in async way if didupdate is call and in direct way if already present. |
…tectObjectRelationImport
fix #26